----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28781/#review70137 -----------------------------------------------------------
Looks good, just a quick question, can the implicit Resources(vector<Resource>) constructor help you here? Or are you intentionally passing around a vector<Resource>? src/master/master.hpp <https://reviews.apache.org/r/28781/#comment115142> Any reason why you're not doing this in the initializer list via the Resources(vector) constructor? - Ben Mahler On Jan. 29, 2015, 12:11 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28781/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2015, 12:11 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-2030 > https://issues.apache.org/jira/browse/MESOS-2030 > > > Repository: mesos-git > > > Description > ------- > > Maintained persisted resources in master memory. > > > Diffs > ----- > > src/master/master.hpp 1d342e56116ad63aade43484b6899ce26f25abfd > src/master/master.cpp 54f26900ac8c63e79a1f89562a988c9a2567d209 > > Diff: https://reviews.apache.org/r/28781/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
