> On Jan. 29, 2015, 5:55 p.m., Alexander Rukletsov wrote: > > What if a user specifies both `--zk` and `--etcd`? Do we want to track it > > and throw at least a warning?
There isn't a good way to do this using <stout/flags> without rewriting a decent chunk of it. I could make the flags have different backing member variables and write the logic outside of flags / in main, but that just adds a lot of code + easy to get wrong / hard to test conditionals without any real value. If someone specifies both on the command line, the last one to be specified wins. Simple enough for an admin to figure out. Note they could also have MESOS_ZK and MESOS_ETCD specified and we wouldn't warn/error. - Cody ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30396/#review70236 ----------------------------------------------------------- On Jan. 29, 2015, 3:58 a.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30396/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2015, 3:58 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1806 > https://issues.apache.org/jira/browse/MESOS-1806 > > > Repository: mesos-git > > > Description > ------- > > Eventually these will be replaced with --masters which handles both > calculating the master group as well as leader election. Currently > etcd can only be used for master election. > > > Diffs > ----- > > docs/configuration.md 22f9e3db7b0e1691018de5fe3dfea3cb908de4b9 > src/master/main.cpp e5e76ce16646eb0244227104038efeae5fbbbb2b > src/slave/main.cpp 42e46c58ab4b16033ac6a73d127968d0803490aa > > Diff: https://reviews.apache.org/r/30396/diff/ > > > Testing > ------- > > > Thanks, > > Cody Maloney > >
