----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30513/#review70600 -----------------------------------------------------------
src/master/validation.hpp <https://reviews.apache.org/r/30513/#comment115806> const Slave* or const Slave&? src/master/validation.cpp <https://reviews.apache.org/r/30513/#comment115807> s/resource/volumes/ .. the current code reads as if you're checking that all resources are persistent volumes, which confused me. src/master/validation.cpp <https://reviews.apache.org/r/30513/#comment115808> if this is all you need, can you pass in the persisted resources instead of a slave? might make future testing easier. - Dominic Hamon On Feb. 2, 2015, 10:40 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30513/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2015, 10:40 a.m.) > > > Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone. > > > Bugs: MESOS-2100 > https://issues.apache.org/jira/browse/MESOS-2100 > > > Repository: mesos > > > Description > ------- > > Added validation for CREATE offer operation. > > This depends on the master validator refactor. Tests will be in a different > patch. > > > Diffs > ----- > > src/master/validation.hpp PRE-CREATION > src/master/validation.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/30513/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
