----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30510/#review70617 -----------------------------------------------------------
src/slave/containerizer/mesos/containerizer.hpp <https://reviews.apache.org/r/30510/#comment115845> In my current working code I've added an Option<string> rootfs to struct Container. Would that be sufficient? src/slave/containerizer/mesos/containerizer.cpp <https://reviews.apache.org/r/30510/#comment115855> How can we ensure that such a filesystem isolator is being used? Shouldn't all of this functionality be in one place!? src/slave/containerizer/mesos/containerizer.cpp <https://reviews.apache.org/r/30510/#comment115876> There ordering considerations here for container paths which have common ancestory beneath the container. this won't work: /bar -> container/foo/bar # fails because foo doesn't yet exist /foo -> container/foo this works: /foo -> container/foo /bar -> container/foo/bar # succeeds, symlink is created inside /foo The filesystem/shared isolator explicitly chose to not implement re-ordering but it does check whether this is attempted and returns an error stating such. src/slave/containerizer/mesos/containerizer.cpp <https://reviews.apache.org/r/30510/#comment115861> This requires the parent of the joined target to exist? "ln -s /persistent1 /container/foo/persistent" will fail if /container/foo doesn't exist src/slave/containerizer/mesos/containerizer.cpp <https://reviews.apache.org/r/30510/#comment115857> I presume this always returns an absolute path? - Ian Downes On Feb. 2, 2015, 10:36 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30510/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2015, 10:36 a.m.) > > > Review request for mesos, Ben Mahler, Ian Downes, Michael Park, and Vinod > Kone. > > > Bugs: MESOS-2031 > https://issues.apache.org/jira/browse/MESOS-2031 > > > Repository: mesos > > > Description > ------- > > Allowed Mesos containerizer to prepare and update volumes. > > Mesos containerizer setup volumes for the container. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.hpp > 802988c90ac872b0cefa5e28f06e6fec98e8d032 > src/slave/containerizer/mesos/containerizer.cpp > d712278428889ebdfd598537690138329d8464f0 > > Diff: https://reviews.apache.org/r/30510/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
