----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30536/#review70689 -----------------------------------------------------------
Ship it! Thanks jie! src/messages/messages.proto <https://reviews.apache.org/r/30536/#comment116039> The two comments here (above `CheckpointResourcesMessage` and `resources`) are a bit redundant, they both refer to the kinds of things that need to be checkpointed..? src/messages/messages.proto <https://reviews.apache.org/r/30536/#comment116035> s/currelnty/currently/ here and above. But, I think you'll want to just change this to use "e.g." like your other comments, otherwise this comment is easily going to become outdated when we add other checkpointed resources. - Ben Mahler On Feb. 3, 2015, 1:10 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30536/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2015, 1:10 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Michael Park, and > Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Renamed persisted resources to checkpointed resources per our discussion. > > This is to avoid confusion with persistent volumes. > > > Diffs > ----- > > src/master/allocator.hpp 318a756e0a8ca1bba6d1144c8160ff24a6b6e646 > src/master/master.hpp 337e00aa46ea127f3667e3383d631c3fb8e22f30 > src/master/master.cpp 10056861b95ed9453c971787982db7d09f09f323 > src/messages/messages.proto c609f500e5e999a7587feb8acfb62aa637824c0a > > Diff: https://reviews.apache.org/r/30536/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
