> On Feb. 3, 2015, 9:06 a.m., Nikita Vetoshkin wrote: > > src/linux/cgroups.cpp, line 2345 > > <https://reviews.apache.org/r/30545/diff/1/?file=845002#file845002line2345> > > > > Wouldn't `new` throw instead of returning null?
I believe it will throw bad_alloc, the check is unnecessary. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30545/#review70720 ----------------------------------------------------------- On Feb. 3, 2015, 5:28 a.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30545/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2015, 5:28 a.m.) > > > Review request for mesos, Dominic Hamon, Ian Downes, and Jie Yu. > > > Bugs: MESOS-2136 > https://issues.apache.org/jira/browse/MESOS-2136 > > > Repository: mesos > > > Description > ------- > > cgroups: added support to listen on memory pressures. > > > Diffs > ----- > > src/linux/cgroups.hpp abf31df1b4dbf6f715f93256b83c9996a45099cf > src/linux/cgroups.cpp 0b136e17907123e814e6011523d8e66a4d66cf98 > src/tests/cgroups_tests.cpp 1eea57f217cd51a6cf0a59ca80823251333563c6 > > Diff: https://reviews.apache.org/r/30545/diff/ > > > Testing > ------- > > > Thanks, > > Chi Zhang > >
