> On Feb. 2, 2015, 6:10 p.m., Ben Mahler wrote: > > I recall Yan and I discussed improving the BoundedRateLimiter abstraction > > to provide a interface that returns failed futures when the bound is > > reached, but I don't think we documented it or the implications of such a > > change. > > > > Mind adding a small TODO for this?
It's documented here: https://issues.apache.org/jira/browse/MESOS-1723 but unfortunately not in the code. - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30511/#review70695 ----------------------------------------------------------- On Feb. 2, 2015, 10:39 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30511/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2015, 10:39 a.m.) > > > Review request for mesos, Ben Mahler and Jiang Yan Xu. > > > Bugs: MESOS-1148 > https://issues.apache.org/jira/browse/MESOS-1148 > > > Repository: mesos > > > Description > ------- > > In the subsequent review a slave related rate limiter is added. So moved the > framework related rate limiters inside 'frameworks'. > > No functional changes. > > > Diffs > ----- > > src/master/master.hpp 337e00aa46ea127f3667e3383d631c3fb8e22f30 > src/master/master.cpp 10056861b95ed9453c971787982db7d09f09f323 > > Diff: https://reviews.apache.org/r/30511/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
