----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30584/#review70855 -----------------------------------------------------------
src/master/master.cpp <https://reviews.apache.org/r/30584/#comment116302> To be consistent, either use shared_ptr for Metrics, or make RateLimiter a raw pointer. src/master/master.cpp <https://reviews.apache.org/r/30584/#comment116303> This doesn't seem to necessary since we have master/slave_removals already (which will be incremented in removeSlave(slave) below)? - Jie Yu On Feb. 3, 2015, 10:36 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30584/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2015, 10:36 p.m.) > > > Review request for mesos, Ben Mahler and Jie Yu. > > > Bugs: MESOS-1148 > https://issues.apache.org/jira/browse/MESOS-1148 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/master.cpp 10056861b95ed9453c971787982db7d09f09f323 > src/master/metrics.hpp 6a43abc914dce24c60b5db57ee01d172c8258e82 > src/master/metrics.cpp 956fe5042d7478d90d4f03059e248694ba2b95e5 > > Diff: https://reviews.apache.org/r/30584/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
