----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30513/#review70908 -----------------------------------------------------------
Patch looks great! Reviews applied: [30513] All tests passed. - Mesos ReviewBot On Feb. 4, 2015, 1:10 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30513/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2015, 1:10 a.m.) > > > Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone. > > > Bugs: MESOS-2100 > https://issues.apache.org/jira/browse/MESOS-2100 > > > Repository: mesos > > > Description > ------- > > Added validation for CREATE offer operation. > > This depends on the master validator refactor. Tests will be in a different > patch. > > > Diffs > ----- > > src/Makefile.am 5b1885de132d527c75fc6431cd2d377f0cb7f242 > src/master/validation.hpp 642c37564375868fae4e398bc4dc8edf2f31c8a4 > src/master/validation.cpp 8804ba6cf0315a22943c25ec24ef594f1cfadf83 > src/tests/master_validation_tests.cpp PRE-CREATION > src/tests/resource_offers_tests.cpp > 24a7eabd40b11f4bbbf30b8251561e73683eef9a > > Diff: https://reviews.apache.org/r/30513/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
