> On Jan. 28, 2015, 8:20 p.m., Niklas Nielsen wrote: > > src/tests/master_tests.cpp, lines 1733-1738 > > <https://reviews.apache.org/r/29883/diff/4/?file=823553#file823553line1733> > > > > Can we use createTasks() here? Take a look at > > https://github.com/apache/mesos/blob/master/src/tests/status_update_manager_tests.cpp#L141
New tests create more complicated tasks and `createTask` doesn't provide enough configuration options. > On Jan. 28, 2015, 8:20 p.m., Niklas Nielsen wrote: > > src/tests/master_tests.cpp, lines 1712-1714 > > <https://reviews.apache.org/r/29883/diff/4/?file=823553#file823553line1712> > > > > See comment below. We could, for clarity, compare against a JSON string > > we put together and parse. When it makes sence (mostly in empty queries). > On Jan. 28, 2015, 8:20 p.m., Niklas Nielsen wrote: > > src/tests/master_tests.cpp, lines 1771-1786 > > <https://reviews.apache.org/r/29883/diff/4/?file=823553#file823553line1771> > > > > How about writing the expected json string, parse it and compare with > > the received one? > > > > Here is a place where we are comparing with that approach: > > https://github.com/apache/mesos/blob/master/src/tests/master_tests.cpp#L2643 That would require knowing the result value for each task, and the code to do so would like almost like the expectations. But the worst part would be to get the timestamp right. If there where a contain option to check json objects, that would be cool. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29883/#review70034 ----------------------------------------------------------- On Jan. 16, 2015, 2:37 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29883/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2015, 2:37 p.m.) > > > Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff. > > > Bugs: MESOS-2157 > https://issues.apache.org/jira/browse/MESOS-2157 > > > Repository: mesos > > > Description > ------- > > Adds endpoints for paths /master/slaves and > /master/frameworks/{framework}/tasks/{task} > > Builds on the abandoned patch 14286. > > Old description: this is WIP that bmahler wants to take on. > > > Diffs > ----- > > src/master/http.cpp 46890be > src/master/master.hpp 26116af > src/master/master.cpp 63ca19a > src/tests/master_tests.cpp 678d27f > > Diff: https://reviews.apache.org/r/29883/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
