----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30597/#review70956 -----------------------------------------------------------
src/exec/exec.cpp <https://reviews.apache.org/r/30597/#comment116426> The timeout in `ExecutorInfo` is the innermost one, the timeout we got from the env var was adjusted by `getExecutorDriverGracePeriod()`. We should either do this adjustment here as well, or do not override the default (modulo we do not allow framework to configure shutdown timeouts), since we have just one timeout per executor. src/launcher/executor.cpp <https://reviews.apache.org/r/30597/#comment116431> Same here, we should adjust the timeout using `getCommandExecutorGracePeriod()`. src/launcher/executor.cpp <https://reviews.apache.org/r/30597/#comment116425> We have one shutdown timeout per executor. Does it make sense to overwrite the timeout on `launchTask()`? - Alexander Rukletsov On Feb. 4, 2015, 2:14 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30597/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2015, 2:14 a.m.) > > > Review request for mesos, Alexander Rukletsov, Niklas Nielsen, and Vinod Kone. > > > Bugs: MESOS-2228 > https://issues.apache.org/jira/browse/MESOS-2228 > > > Repository: mesos > > > Description > ------- > > Now the executor and task graceful times are being read, note thought that > they are still being over-written by the slave. See here: > https://reviews.apache.org/r/30601/ > > > Diffs > ----- > > src/exec/exec.cpp aada24664dba9060a92230e25689c89852585443 > src/launcher/executor.cpp 1cf28f168cac6e8c7e98686a35509c2b4e052504 > > Diff: https://reviews.apache.org/r/30597/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
