----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30624/#review70989 -----------------------------------------------------------
Ship it! src/tests/paths_tests.cpp <https://reviews.apache.org/r/30624/#comment116478> 2 lines apart here please:) src/tests/paths_tests.cpp <https://reviews.apache.org/r/30624/#comment116480> s/Pid/LibprocessPid/ Because we also have forked pid. - Jie Yu On Feb. 4, 2015, 5:43 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30624/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2015, 5:43 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-2314 > https://issues.apache.org/jira/browse/MESOS-2314 > > > Repository: mesos > > > Description > ------- > > Refactor and increase test coverage for slave paths > > > Diffs > ----- > > src/tests/paths_tests.cpp 417aa51b99d54055ad7254b4f274fb59d0794ca6 > > Diff: https://reviews.apache.org/r/30624/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
