----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30621/#review71003 -----------------------------------------------------------
Patch looks great! Reviews applied: [30033, 30034, 30036, 30037, 30039, 30006, 30124, 30173, 30621] All tests passed. - Mesos ReviewBot On Feb. 4, 2015, 4:55 p.m., Bernd Mathiske wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30621/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2015, 4:55 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Till Toenshoff, and > Timothy Chen. > > > Bugs: MESOS-2072 > https://issues.apache.org/jira/browse/MESOS-2072 > > > Repository: mesos > > > Description > ------- > > Moved the URI type separation code (distinguishes http, hdfs, local copying, > etc.) from mesos-fetcher to the fetcher process/actor, since it is going to > be reused by download size queries when we introduce fetcher cache > management. Also factored out URI validation, which will be used the same way > by mesos-fetcher and the fetcher process/actor. > > > Diffs > ----- > > src/launcher/fetcher.cpp fed0105946da579a38357a30e7ae56e646e05b89 > src/slave/containerizer/fetcher.hpp > 1db0eaf002c8d0eaf4e0391858e61e0912b35829 > src/slave/containerizer/fetcher.cpp > d290f95251def3952c5ee34f600e1d71467f6293 > > Diff: https://reviews.apache.org/r/30621/diff/ > > > Testing > ------- > > None. Will be tested together with the rest of MESOS-2072. > > > Thanks, > > Bernd Mathiske > >
