----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30595/#review71090 -----------------------------------------------------------
Ship it! - Niklas Nielsen On Feb. 3, 2015, 6:14 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30595/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2015, 6:14 p.m.) > > > Review request for mesos, Alexander Rukletsov, Niklas Nielsen, and Vinod Kone. > > > Bugs: MESOS-2228 > https://issues.apache.org/jira/browse/MESOS-2228 > > > Repository: mesos > > > Description > ------- > > Turns out the slave was actually ignoring the executor's grace period when > setting up the timeout! > > Note that this is still being overriden with the slave's flag, see: > https://reviews.apache.org/r/30601/ > > > Diffs > ----- > > src/slave/slave.cpp a8b262174ab5c9a524db8318d3d1438cd75a702b > > Diff: https://reviews.apache.org/r/30595/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
