----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30601/#review71062 -----------------------------------------------------------
include/mesos/mesos.proto <https://reviews.apache.org/r/30601/#comment116598> This is the only place the framework writer sees grace period related docs. Maybe worthwhile documenting SIGTERM -> SIGKILL escalation. src/exec/exec.cpp <https://reviews.apache.org/r/30601/#comment116609> Fly by change? src/slave/constants.hpp <https://reviews.apache.org/r/30601/#comment116608> We should probably make EXECUTOR_SHUTDOWN_GRACE_PERIOD_MAXIMUM configurable through slave flags. Let's create a ticket for that. src/slave/containerizer/containerizer.cpp <https://reviews.apache.org/r/30601/#comment116689> Again, If duration if large: 15 minutes and EXECUTOR_SHUTDOWN_GRACE_PERIOD_MAXIMUM small: 1 minute. You have a 15 minute timeout (if my mental boolean logic works) src/slave/slave.cpp <https://reviews.apache.org/r/30601/#comment116604> Did you want to do max() here? Then the executor duration can exceed EXECUTOR_SHUTDOWN_GRACE_PERIOD_MAXIMUM and it actually works as lower limit. - Niklas Nielsen On Feb. 4, 2015, 2:46 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30601/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2015, 2:46 p.m.) > > > Review request for mesos, Alexander Rukletsov, Niklas Nielsen, and Vinod Kone. > > > Bugs: MESOS-2228 > https://issues.apache.org/jira/browse/MESOS-2228 > > > Repository: mesos > > > Description > ------- > > Now the slave doesn't completely ignore the grace period, note that there is > a bound of 1 minute for now. > > > Diffs > ----- > > include/mesos/mesos.proto 28612168c66d85679b35d743e96954770f37daec > src/exec/exec.cpp aada24664dba9060a92230e25689c89852585443 > src/slave/constants.hpp 761cfafb3b1b342af4d1dbdb2dec39a45dd62794 > src/slave/constants.cpp 83d9fc1cd385722deb31883c17c824fd0e1de8a6 > src/slave/containerizer/containerizer.cpp > 421bb868b353e644578fa27f04bdd636bfc89134 > src/slave/slave.cpp a8b262174ab5c9a524db8318d3d1438cd75a702b > src/tests/slave_tests.cpp e7e2af63da785644f3f7e6e23607c02be962a2c6 > > Diff: https://reviews.apache.org/r/30601/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
