----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30584/#review71099 -----------------------------------------------------------
Ship it! TIL: Americans spell it "canceled", not "cancelled" :) src/master/master.cpp <https://reviews.apache.org/r/30584/#comment116699> It's not consistent, but I originally pre-incremented all the metrics. Later, we decided just post-increment them like we do with integer types in most places (see the ack metrics). src/master/metrics.cpp <https://reviews.apache.org/r/30584/#comment116696> Indentation? - Ben Mahler On Feb. 5, 2015, 12:13 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30584/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2015, 12:13 a.m.) > > > Review request for mesos, Ben Mahler and Jie Yu. > > > Bugs: MESOS-1148 > https://issues.apache.org/jira/browse/MESOS-1148 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/master.hpp cd37ee9d3c57bcd91f08cd402ec1e4a09d9e42ee > src/master/master.cpp 69b945df58c173322b95aeae9cf4ed70329c4bb3 > src/master/metrics.hpp 6a43abc914dce24c60b5db57ee01d172c8258e82 > src/master/metrics.cpp 956fe5042d7478d90d4f03059e248694ba2b95e5 > > Diff: https://reviews.apache.org/r/30584/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
