> On Jan. 31, 2015, 1:05 a.m., Vinod Kone wrote: > > src/tests/mesos.hpp, line 676 > > <https://reviews.apache.org/r/29890/diff/7/?file=841772#file841772line676> > > > > why does T have to be a HierarchicalDRFAllocator instead of an > > Allocator or MesosAllocator? > > Alexander Rukletsov wrote: > We expect a "real" allocator here, `HierarchicalDRFAllocator` is the only > "real" one we have now.
That's fine. The class will need to be instantiated with a real 'T'. If 'T' is HierarchicalDRFAllocator what's the point of template? Do you imagine in future we would subclass HierarchicalDRFAllocator? Previously 'T' was an abstract class 'AllocatorProcess', so I'm not sure why is this any different. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29890/#review70462 ----------------------------------------------------------- On Feb. 4, 2015, 4:47 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29890/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2015, 4:47 p.m.) > > > Review request for mesos, Bernd Mathiske, Niklas Nielsen, and Vinod Kone. > > > Bugs: MESOS-2213 > https://issues.apache.org/jira/browse/MESOS-2213 > > > Repository: mesos > > > Description > ------- > > Introduce a basic Allocator interface that every allocator should implement. > This interface does not require allocators to be based on libprocess process. > For allocators they do implement allocation logic via an internal libprocess > process, a special wrapper is provided. Allocator uses and tests are updated > to use Allocator type instead of AllocatorProcess. > > > Diffs > ----- > > src/local/local.cpp 76e73a4 > src/master/allocator.hpp 318a756 > src/master/hierarchical_allocator_process.hpp 6b44892 > src/master/main.cpp e5e76ce > src/tests/cluster.hpp 90fda52 > src/tests/fault_tolerance_tests.cpp f927d4a > src/tests/hierarchical_allocator_tests.cpp f44d9e9 > src/tests/master_allocator_tests.cpp 018a6cc > src/tests/master_authorization_tests.cpp 20adaa9 > src/tests/master_tests.cpp 678d27f > src/tests/mesos.hpp 17c2d8f > src/tests/mesos.cpp 5ed4df5 > src/tests/partition_tests.cpp fea7801 > src/tests/rate_limiting_tests.cpp 7f5ca25 > src/tests/resource_offers_tests.cpp 24a7eab > src/tests/slave_recovery_tests.cpp 7e2e63d > > Diff: https://reviews.apache.org/r/29890/diff/ > > > Testing > ------- > > make distcheck (Ubuntu, OS X) > > > Thanks, > > Alexander Rukletsov > >
