----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27531/#review71492 -----------------------------------------------------------
src/master/master.cpp <https://reviews.apache.org/r/27531/#comment117233> don't need this if condition because we are inside if (terminated). - Vinod Kone On Feb. 6, 2015, 6:42 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27531/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2015, 6:42 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-1830 > https://issues.apache.org/jira/browse/MESOS-1830 > > > Repository: mesos > > > Description > ------- > > Update metrics in Master to match the source and reason split for task > statuses. > > > Diffs > ----- > > src/master/master.hpp c3c77f840f089c5754c764e7f150a3c1971d311f > src/master/master.cpp 22fece79c6e511a1b61eb674d7f82216e7a25e00 > src/master/metrics.hpp ee8b5bc76336ece9192455b216187482cee29420 > src/master/metrics.cpp 0b3b91e744cdb76cd843edfcf34b12b842fcb06e > src/slave/slave.hpp 9adee17cb94a72f0e1e139b3fd8978a9a1ff6237 > src/slave/slave.cpp 336e8776be656c5e6ad1b0d997f54c307f4559f8 > src/tests/master_authorization_tests.cpp > 6fd0efa444dce5203e2e755d4de0483fcaa277f8 > src/tests/master_slave_reconciliation_tests.cpp > 09742855c9fcd6bd10ab79af582b14fba2e6b609 > src/tests/master_tests.cpp 62ba35b9c3f999c59a95bffb01b8b82cc543a34f > src/tests/mesos.hpp 83a369968ab2403fa341829ac5d11f7243095190 > src/tests/mesos.cpp 21a405366f56c963611324076efe775f85b9d9f7 > src/tests/rate_limiting_tests.cpp 8b55bffff0b7713806fc0bcc63d8a7097a8408e0 > src/tests/slave_tests.cpp 68a6498cd86723e571b262b2495b4b504e744428 > > Diff: https://reviews.apache.org/r/27531/diff/ > > > Testing > ------- > > added metric tests to master tests > make check > > > Thanks, > > Dominic Hamon > >
