> On Feb. 5, 2015, 1:58 a.m., Adam B wrote: > > src/launcher/fetcher.cpp, lines 326-330 > > <https://reviews.apache.org/r/30039/diff/5/?file=833515#file833515line326> > > > > You return work_directory if you extract, but just return 'downloaded' > > otherwise? What's the logic here? workDir (when extracting) vs. > > workDir+basename? Does this need a comment?
The elseif branch has been deleted. It is fine to return "downloaded" in every successful case. - Bernd ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30039/#review71181 ----------------------------------------------------------- On Jan. 25, 2015, 9:21 a.m., Bernd Mathiske wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30039/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2015, 9:21 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Till Toenshoff, and > Timothy Chen. > > > Bugs: MESOS-2069 > https://issues.apache.org/jira/browse/MESOS-2069 > > > Repository: mesos > > > Description > ------- > > Enables the fetcher cache actions prepared in the preceding patches by > implementing them in the mesos fetcher program. Also general cleanup of this > file, which is necessary to reduce complexity in and better understand the > resulting source code. > > > Diffs > ----- > > src/launcher/fetcher.cpp fed0105946da579a38357a30e7ae56e646e05b89 > > Diff: https://reviews.apache.org/r/30039/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Bernd Mathiske > >
