----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30694/#review71526 -----------------------------------------------------------
Ship it! src/master/master.hpp <https://reviews.apache.org/r/30694/#comment117271> Should we be failing when there's a checkpointed resource that we've ignored here? That is, do you want an else block with a LOG(FATAL) to ensure we don't miss checkpointed resources here? - Ben Mahler On Feb. 6, 2015, 11:31 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30694/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2015, 11:31 p.m.) > > > Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone. > > > Bugs: MESOS-2100 > https://issues.apache.org/jira/browse/MESOS-2100 > > > Repository: mesos > > > Description > ------- > > Fixed bugs in CREATE/DESTROY operation handlers and added tests. > > > Diffs > ----- > > include/mesos/resources.hpp 3b57568c10233a0c692787de6464f21af5eaadf4 > src/Makefile.am 93537d17d3c7604a8532ee1453e405630c481ddc > src/master/master.hpp c3c77f840f089c5754c764e7f150a3c1971d311f > src/master/master.cpp 22fece79c6e511a1b61eb674d7f82216e7a25e00 > src/tests/persistent_volume_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/30694/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
