> On Feb. 4, 2015, 11:04 p.m., Adam B wrote:
> > src/slave/containerizer/fetcher.cpp, lines 458-459
> > <https://reviews.apache.org/r/30037/diff/9-11/?file=838555#file838555line458>
> >
> > Since cacheFile.get().get()->name is actually a parameter to
> > path::join(), it should not sit at the complete() indentation level.
> > Preferred:
> > `cacheFile.get()->complete(
> > path::join(cacheDirectory, cacheFile.get().get()->name));`
Correct, but the proposed fix would be more than 80 chars, so I went for
cacheFile.get()->complete(
path::join(cacheDirectory, cacheFile.get().get()->name));
- Bernd
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30037/#review71175
-----------------------------------------------------------
On Jan. 28, 2015, 9:33 a.m., Bernd Mathiske wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30037/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2015, 9:33 a.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Till Toenshoff, and
> Timothy Chen.
>
>
> Bugs: MESOS-2069
> https://issues.apache.org/jira/browse/MESOS-2069
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Extends the fetcher info protobuf with "actions" (fetch directly, through
> cache, retrieve from cache). Switches the basis for dealing with uris to
> "items", which contain the uri, the action, and potentially and cache file
> name. Refactors fetch() and run(), so there is only one of each. Introduces
> about half of the actual cache logic, including a hashmap of cache file
> objects for bookkeeping and basic operations on it.
>
>
> Diffs
> -----
>
> include/mesos/fetcher/fetcher.proto
> facb87b92bf3194516f636dcc348e136af537721
> src/launcher/fetcher.cpp fed0105946da579a38357a30e7ae56e646e05b89
> src/slave/containerizer/fetcher.hpp
> 1db0eaf002c8d0eaf4e0391858e61e0912b35829
> src/slave/containerizer/fetcher.cpp
> d290f95251def3952c5ee34f600e1d71467f6293
>
> Diff: https://reviews.apache.org/r/30037/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Bernd Mathiske
>
>
