----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28809/#review71666 -----------------------------------------------------------
Ship it! src/slave/slave.cpp <https://reviews.apache.org/r/28809/#comment117529> s/delivery/delivery per connection/ src/slave/slave.cpp <https://reviews.apache.org/r/28809/#comment117532> s/we create ephemeral connections/master creates multiple connections to the slave in some cases (e.g., persistent socket to slave breaks and master uses ephemeral socket)/ src/slave/slave.cpp <https://reviews.apache.org/r/28809/#comment117533> s/we are expecting the following cases/there are two cases to consider/ src/slave/slave.cpp <https://reviews.apache.org/r/28809/#comment117534> s/reconcile the state/reconcile the state with the slave/ src/slave/slave.cpp <https://reviews.apache.org/r/28809/#comment117535> Also mention that, since master is the source of truth for reservations the inconsistency is not exposed to frameworks? src/slave/slave.cpp <https://reviews.apache.org/r/28809/#comment117536> s/If/When/ src/tests/persistent_volume_tests.cpp <https://reviews.apache.org/r/28809/#comment117538> s/registration/re-registration/ - Vinod Kone On Feb. 9, 2015, 5:59 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28809/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2015, 5:59 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-2031 > https://issues.apache.org/jira/browse/MESOS-2031 > > > Repository: mesos > > > Description > ------- > > Started to maintain and checkpoint persisted resource in slave. That includes: > 1) responds to update resources message > 2) checkpoint resources > 3) recover checkpointed resources > 4) send checkpointed resources during register/reregister > > > Diffs > ----- > > src/slave/slave.hpp 9adee17cb94a72f0e1e139b3fd8978a9a1ff6237 > src/slave/slave.cpp fff2d725fe49eee984d9151cfb2131202c47994f > src/slave/state.hpp 04084fc5c9130bf7d824b2ced4eb7053a995edd0 > src/tests/persistent_volume_tests.cpp > ffbaedddbd21d0eb7964be0bff4368384389b0a0 > > Diff: https://reviews.apache.org/r/28809/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
