----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30784/#review71674 -----------------------------------------------------------
src/tests/master_allocator_tests.cpp <https://reviews.apache.org/r/30784/#comment117540> Can we use FutureArg for thse to be explicit about the fact that we're expecting them to be ready? Right now it looks like these are assumed to be set after `AWAIT_READY(removeFramework)`? Could you then move down the EXPECT_CALL as it was before? That was capturing that the first call must occur before removeFramework is ready, but we've lost that now? src/tests/master_allocator_tests.cpp <https://reviews.apache.org/r/30784/#comment117541> For all of these "driver2" shutdown expectations, can you put them before the stop the driver down below? Also, use DoDefault() for these. - Ben Mahler On Feb. 9, 2015, 4:02 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30784/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2015, 4:02 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-2324 > https://issues.apache.org/jira/browse/MESOS-2324 > > > Repository: mesos > > > Description > ------- > > Fixed flaky test MasterAllocatorTest/0.OutOfOrderDispatch. > > > Diffs > ----- > > src/tests/master_allocator_tests.cpp > 1eebefd2e423e4bb89d76ed7b7d8acc9d1bb7760 > > Diff: https://reviews.apache.org/r/30784/diff/ > > > Testing > ------- > > make -j check GTEST_FILTER=MasterAllocatorTest/0.OutOfOrderDispatch > > > Thanks, > > Jiang Yan Xu > >
