> On Feb. 5, 2015, 1:24 a.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/containerizer.hpp, line 260 > > <https://reviews.apache.org/r/30509/diff/2/?file=849046#file849046line260> > > > > I wonder if we should consolidate our terminalogy for the working > > directory. > > I've been calling it sandbox in the docker containerizer, and sometimes > > it's referred to workDir, and here just directory. > > > > Can we just call this sandbox?
I agree that we should make it consistent. However, I have a different opinion about whether the executor working directory should be named as 'sandbox'. The main reason is that we may want to add more stuff to executor's working directory and make 'sandbox' the actual sandbox for executors/tasks. For example, the following layout: ``` <executor_working_dir> |--- sandbox/ // the actual sandbox for executor/tasks |--- volumes/ // volumes for the executor/tasks, will be bind mount into container under /mnt/mesos/volumes ``` Since MesosContainerizer currently uses 'directory' as the executor working directory already, I would rather keep it consistent for now. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30509/#review71118 ----------------------------------------------------------- On Feb. 9, 2015, 6 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30509/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2015, 6 p.m.) > > > Review request for mesos, Ben Mahler, Ian Downes, Michael Park, and Vinod > Kone. > > > Bugs: MESOS-2031 > https://issues.apache.org/jira/browse/MESOS-2031 > > > Repository: mesos > > > Description > ------- > > Added executor working directory to Container struct in Mesos containerizer. > > The executor directory is needed when linking persistent volumes inside the > container. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.hpp > b3aafe4efa9f3469d7a3fd39243ad66b46d6a54d > src/slave/containerizer/mesos/containerizer.cpp > fa40d47aee7803833bcde6cce1e86a21d7cf27d0 > > Diff: https://reviews.apache.org/r/30509/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
