----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30338/#review71813 -----------------------------------------------------------
Ship it! Ship It! - Niklas Nielsen On Feb. 9, 2015, 6:53 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30338/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2015, 6:53 p.m.) > > > Review request for mesos, Ian Downes, Niklas Nielsen, Till Toenshoff, and > Vinod Kone. > > > Bugs: MESOS-2096 > https://issues.apache.org/jira/browse/MESOS-2096 > > > Repository: mesos > > > Description > ------- > > [4/9] Build Mesos Modules outside Mesos source tree. > > The struct is constructed from some fields of RunState and passed on to > Isolators. This further allows us to do cleanup various isolators/launchers. > The goal was to remove the dependency on RunState so that we > can eventually expose slave/containerizer/isolator.hpp as a public header. > > > Diffs > ----- > > src/slave/containerizer/external_containerizer.hpp > 12968781b47cbf53bef2529d6bbc3819b09c36e9 > src/slave/containerizer/isolator.hpp > e39a8a5e7ecd3273cabab2d7f4038eb7a6d88bb3 > src/slave/containerizer/isolator.cpp > bb4da46f2d0984956b57ffbb065dc3cc43ff8262 > src/slave/containerizer/isolators/cgroups/cpushare.hpp > 1050af7394fa7b181ce5e1d1841c397da7649b84 > src/slave/containerizer/isolators/cgroups/cpushare.cpp > 6554ca3d8c45f449ca5414c695efe813f31a101b > src/slave/containerizer/isolators/cgroups/mem.hpp > 4de5c646d2869f5893158a260f973ec098bcc33e > src/slave/containerizer/isolators/cgroups/mem.cpp > 0bb4039ba83698e663ab0527f90c46ed7bd11bf5 > src/slave/containerizer/isolators/cgroups/perf_event.hpp > 6bf885820d09d6ee3190b465851207a46dacd038 > src/slave/containerizer/isolators/cgroups/perf_event.cpp > f94eeaecbf4b60b5a29b54fff8eb2db9c30e8bef > src/slave/containerizer/isolators/filesystem/shared.hpp > a5b5ca1dd598ea35aa6d08ded93f881eb6bc2c65 > src/slave/containerizer/isolators/filesystem/shared.cpp > 85a5ade7fd739f95c7ab940641358af3dc76acef > src/slave/containerizer/isolators/namespaces/pid.hpp > 7052a033c1beeb8dab73ef0f4e75185d6130650a > src/slave/containerizer/isolators/namespaces/pid.cpp > 0ad102d00276b4f5a3141ac16eb7ed186690e4be > src/slave/containerizer/isolators/network/port_mapping.hpp > 1e4ed3d3929b648308dfd03d1f8b578988cf079d > src/slave/containerizer/isolators/network/port_mapping.cpp > 361e33b013fd37dfbcda701bf13c28b3420160ef > src/slave/containerizer/isolators/posix.hpp > b6d289bc2a7e9d0e86c2a2bf7134b9612754830f > src/slave/containerizer/isolators/posix/disk.hpp > 58a06c7f47b33006705b1ded8f4fdcff95cabb2d > src/slave/containerizer/isolators/posix/disk.cpp > b2be552035ced393e5e0c0e41e701fcbdcddf190 > src/slave/containerizer/launcher.hpp > b6fab38865c2be576ced5486a55ae931730572ed > src/slave/containerizer/launcher.cpp > f2267adbfabc936c7f99711b53e2bf62de37a18a > src/slave/containerizer/linux_launcher.hpp > 0d630facc90f55ed7f9559e66a5349a30337528f > src/slave/containerizer/linux_launcher.cpp > 8417160e756018da8233c7a3287e35781b5743da > src/slave/containerizer/mesos/containerizer.hpp > b3aafe4efa9f3469d7a3fd39243ad66b46d6a54d > src/slave/containerizer/mesos/containerizer.cpp > fa40d47aee7803833bcde6cce1e86a21d7cf27d0 > src/tests/isolator.hpp 7c40f3cb419057c91b307f164edcdb724d45c50d > > Diff: https://reviews.apache.org/r/30338/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Kapil Arya > >
