> On Feb. 10, 2015, 2:01 p.m., Niklas Nielsen wrote: > > src/Makefile.am, line 1293 > > <https://reviews.apache.org/r/29607/diff/10/?file=859559#file859559line1293> > > > > Copy past :) Do we want this comment for every module? I think just > > having it on the first one would suffice
I think it's helpful to have the comment here as well, so that if someone copies the block (i.e. to create a out-of-tree module), they know the context. - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29607/#review71832 ----------------------------------------------------------- On Feb. 10, 2015, 2:03 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29607/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2015, 2:03 p.m.) > > > Review request for mesos, Niklas Nielsen and Till Toenshoff. > > > Bugs: MESOS-2338 > https://issues.apache.org/jira/browse/MESOS-2338 > > > Repository: mesos > > > Description > ------- > > Module libraries (libtestisolator, libtestauthentication, libtesthook, and > libexamplemodule) are > needed for Mesos test suite only. > > > Diffs > ----- > > src/Makefile.am fae36ac2d539a9aa4c7cd0035275ff6b9260ea49 > > Diff: https://reviews.apache.org/r/29607/diff/ > > > Testing > ------- > > Verified that the files are not installed after a 'make install'. > > > Thanks, > > Kapil Arya > >
