> On Feb. 11, 2015, 7:16 a.m., Benjamin Hindman wrote: > >
Took care of the minor issue and committed. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30194/#review71938 ----------------------------------------------------------- On Feb. 9, 2015, 12:43 a.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30194/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2015, 12:43 a.m.) > > > Review request for mesos, Benjamin Hindman and Ken Sipe. > > > Bugs: mesos-1806 > https://issues.apache.org/jira/browse/mesos-1806 > > > Repository: mesos > > > Description > ------- > > More cases kept being added which dealt with 'file://' urls, parsing > them, reading from the file, and then handling the argument as though > the file:// wasn't there. > > We now always read an argument from a file in the argument parser if > it begins with 'file://'. If you want to pass an argument which is a > filename, then just use the path directly. > > Adds a new fetch<> step to parsing an argument which occurs before > parse<>. This fetch can perform actions such as reading a file from > the filesystem, or fetching a resource from a URL. > > This is added to alleviate the need to keep adding more code to deal > with 'file://' URLs in each new case where someone needs one. > > The patchset introduces no outside-visible argument changes, but it > does require developers who want to specify 'give me a path' to ask > for that path using the new 'Path' type rather than a string, since > for 'file://' URLs, we want to keep the filename. > > All existing instances have been modified. > > Specifying reading JSON from a file using an absolute path rather than > a file:// URI has been deprecated, and will now log a deprecation > message when used. > > From a quick pass on JIRA (first page of results in JIRA searching for > files): This would have prevented: MESOS-1368, MESOS-1635, MESOS-1590 > And simplifies supporting: MESOS-18 > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > dc3ef53dbb00bd205497bd86eec0c05e6b4395f1 > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/fetch.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp > f4b7a95a8ca1e625c3dac7823f4db47f7b4f2c10 > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp > 120946909cd19653ae5f71d401b5c9ea6d8228cd > 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp > 9f8f52040f22f995fb8b66a4078a0149ba26cca7 > 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp > 3b60ff824bada441cd657e10ca01762085a6d099 > > Diff: https://reviews.apache.org/r/30194/diff/ > > > Testing > ------- > > make distcheck when #30195 has been applied > > > Thanks, > > Cody Maloney > >
