> On Feb. 9, 2015, 10:42 p.m., Vinod Kone wrote: > > src/tests/slave_tests.cpp, lines 1577-1580 > > <https://reviews.apache.org/r/30601/diff/4/?file=851253#file851253line1577> > > > > Why do we need 2 expectations here?
To check the edge case (timeout is set to 0) and to document the expected behaviour in order to catch in case it changes. An alternative approach discussed in the design doc was to set all timeouts to 0, but we opted for the current solution for consistency. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30601/#review71696 ----------------------------------------------------------- On Feb. 5, 2015, 9:02 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30601/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2015, 9:02 p.m.) > > > Review request for mesos, Alexander Rukletsov, Niklas Nielsen, and Vinod Kone. > > > Bugs: MESOS-2228 > https://issues.apache.org/jira/browse/MESOS-2228 > > > Repository: mesos > > > Description > ------- > > Now the slave doesn't completely ignore the grace period, note that there is > a bound of 1 minute for now. > > > Diffs > ----- > > include/mesos/mesos.proto 28612168c66d85679b35d743e96954770f37daec > src/slave/constants.hpp 761cfafb3b1b342af4d1dbdb2dec39a45dd62794 > src/slave/constants.cpp 83d9fc1cd385722deb31883c17c824fd0e1de8a6 > src/slave/containerizer/containerizer.cpp > 421bb868b353e644578fa27f04bdd636bfc89134 > src/slave/slave.cpp a8b262174ab5c9a524db8318d3d1438cd75a702b > src/tests/slave_tests.cpp e7e2af63da785644f3f7e6e23607c02be962a2c6 > > Diff: https://reviews.apache.org/r/30601/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
