-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28698/
-----------------------------------------------------------
(Updated Feb. 12, 2015, 2:46 a.m.)
Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and
Vinod Kone.
Changes
-------
Depends on the new filter abstraction and renaming changes.
Repository: mesos
Description
-------
## Overview
With the introduction of `Resource::ReserverType`, the `Resources` object need
to consider it in some contexts.
### `static bool Resources::reserved(const Resource &, const ReserverType&);`
Returns true if the given resource is reserved for the given reserverType.
### `Resources::validate`
If `role == `"*"`, then `reserverType` must be `Resource::SLAVE`.
### `Resources::flatten`
`flatten` takes a `Resource::ReserverType` and set the resource with it as
well as the role.
### `Resources::find`
We need to prefer resources that match role and ReserverType over resources
that only match the role.
### Resources Comparators
`operator==`, `addable`, `subtractable` need to consider `ReserverType`.
Diffs
-----
include/mesos/resources.hpp c7cc46e0183ea97013dd088a717da6c0e6ed5cf0
src/common/resources.cpp 98371f6873482d0cdbefeb279b58ae6cc680a88f
Diff: https://reviews.apache.org/r/28698/diff/
Testing
-------
make check
Thanks,
Michael Park
