> On Feb. 3, 2015, 11:23 p.m., Bill Farner wrote: > > Is there a shortcoming in the executor API that prevents this from being an > > independent binary? > > Timothy Chen wrote: > Hi Bill, this is going to be a binary on itself just like command > exexutor. Do you have something else in mind?
Sorry for my late reply, gmail filter mishap on my end. It's my understanding that this will not be a standalone binary, but a part of the slave binary (which, IIUC, is true of the command executor as well). If this is incorrect, please excuse my ignorance and read no further. The distinction worrying me is that this is creating a first-class executor implementation within mesos itself. I agree that in some respects this is not dissimilar from the command executor, though i think coupling to a shell is not as extreme as a third-party container system. This sets a risky precedent for mesos, as it allows the project to make short-sighted decisions coupling to the first-class executor, and fail to generalize its APIs in ways that limits other executors when compared to those built in to the slave. - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29329/#review70849 ----------------------------------------------------------- On Jan. 17, 2015, 1:26 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29329/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2015, 1:26 a.m.) > > > Review request for mesos, Benjamin Hindman and Bernd Mathiske. > > > Repository: mesos > > > Description > ------- > > Add executor for docker containerizer, replaces the usage of command executor > > > Diffs > ----- > > src/Makefile.am 07bea1f > src/docker/executor.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/29329/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
