> On Feb. 11, 2015, 12:08 a.m., Ben Mahler wrote: > > It might be time to introduce os::stat and os::lstat wrappers to avoid > > needing to introduce so many special case functions. > > Bernd Mathiske wrote: > That would reduce portability.
Oh? Could you elaborate please? :) To be specific, I'm referring to `Try<os::Stat> os::stat()` where `os::Stat` only contains what is specified by [POSIX](http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/sys_stat.h.html) and uses things like `Bytes`, etc. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30609/#review71880 ----------------------------------------------------------- On Feb. 10, 2015, 11:19 a.m., Bernd Mathiske wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30609/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2015, 11:19 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Till Toenshoff, and > Timothy Chen. > > > Bugs: MESOS-2072 > https://issues.apache.org/jira/browse/MESOS-2072 > > > Repository: mesos > > > Description > ------- > > This returns a file's size as reported by lstat(). (Not stat(). It is desired > that in case of a link, the size of the link, not the size of the referenced > file, is returned.) > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 8a4fda97ee29c185471a69f60803efc193cbe922 > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > 8a2d445c2edaa70da0e7b50e14ef88b2d9224a16 > > Diff: https://reviews.apache.org/r/30609/diff/ > > > Testing > ------- > > Wrote a simple test that creates a file and tests its size, and also checks > if a non-existing file yields an error. > > > Thanks, > > Bernd Mathiske > >
