----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31012/#review72746 -----------------------------------------------------------
src/tests/cgroups_tests.cpp <https://reviews.apache.org/r/31012/#comment118801> what is this indent? src/tests/cgroups_tests.cpp <https://reviews.apache.org/r/31012/#comment118802> return stat().get(metric).get(); src/tests/cgroups_tests.cpp <https://reviews.apache.org/r/31012/#comment118803> ASSERT_NOTNULL? src/tests/cgroups_tests.cpp <https://reviews.apache.org/r/31012/#comment118804> ASSERT_SOME - not removing this path will cause problems for other tests. src/tests/cgroups_tests.cpp <https://reviews.apache.org/r/31012/#comment118806> comparing a uint64_t to a signed 0 is unlikely to compile on all platforms. src/tests/cgroups_tests.cpp <https://reviews.apache.org/r/31012/#comment118805> ASSERT_NE src/tests/cgroups_tests.cpp <https://reviews.apache.org/r/31012/#comment118808> comparing a size_t to a uint64_t is not going to compile on 32-bit platforms. - Dominic Hamon On Feb. 13, 2015, 10:08 a.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31012/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2015, 10:08 a.m.) > > > Review request for mesos, Dominic Hamon, Ian Downes, and Jie Yu. > > > Bugs: mesos-2136 > https://issues.apache.org/jira/browse/mesos-2136 > > > Repository: mesos > > > Description > ------- > > cgroups: added tests for memory statistics. > > > Diffs > ----- > > src/tests/cgroups_tests.cpp 9d50a47c939f5f136c85fdcc555459512c6f2259 > > Diff: https://reviews.apache.org/r/31012/diff/ > > > Testing > ------- > > > Thanks, > > Chi Zhang > >
