----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31139/#review72844 -----------------------------------------------------------
Ship it! Thanks Joris! I only have trivial comments, so I'll take these up for you before committing. 3rdparty/libprocess/src/event_loop.hpp <https://reviews.apache.org/r/31139/#comment118957> Should we add a TODO for rvalue version? 3rdparty/libprocess/src/libevent.cpp <https://reviews.apache.org/r/31139/#comment118950> It looks a bit weird to have a partial constructor, either we should take the timer as well, or just assign as before. 3rdparty/libprocess/src/libevent.cpp <https://reviews.apache.org/r/31139/#comment118956> Was this fixing another bug? It looks ok at first glace, but let's take this up independently, since I don't have any libevent context yet :) - Ben Mahler On Feb. 18, 2015, 12:27 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31139/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2015, 12:27 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Repository: mesos > > > Description > ------- > > This allows us to pass arbitrary state along (by binding it into the lambda) > with each delay call so we don't lose track of why we're being called back. > > > Diffs > ----- > > 3rdparty/libprocess/src/event_loop.hpp > 34e9f1dc95dcc4ee2bd1793e71725907f281c5c8 > 3rdparty/libprocess/src/libev.cpp 0e8d44cdc1daa258faafc30b5caf4a827ce6cbc1 > 3rdparty/libprocess/src/libevent.cpp > 28c2cf7f49cc153158f2a470a1812e35f7d4b93a > > Diff: https://reviews.apache.org/r/31139/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Joris Van Remoortere > >
