----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30995/#review72927 -----------------------------------------------------------
First pass, found some minor typos/nits. Still considering whether we might want a different API than 4 bools or a `hashset<string>`, but if we do keep the hashset, the strings should probably more closely match the actual endpoints they represent (e.g. "whatever.json") src/files/files.hpp <https://reviews.apache.org/r/30995/#comment119045> s/permission/access/? src/files/files.cpp <https://reviews.apache.org/r/30995/#comment119046> s/itseld/itself/ src/files/files.cpp <https://reviews.apache.org/r/30995/#comment119047> s/enpoint/endpoint/ src/files/files.cpp <https://reviews.apache.org/r/30995/#comment119048> s/disallowed/forbidden/? src/files/files.cpp <https://reviews.apache.org/r/30995/#comment119050> Remove unnecessary blank line src/files/files.cpp <https://reviews.apache.org/r/30995/#comment119056> Why match "browse" instead of the entire endpoint string, "/browse.json"? Couldn't there potentially be another separate endpoint that "browse" or "/browse" route to? src/tests/files_tests.cpp <https://reviews.apache.org/r/30995/#comment119053> s/permission/access/? hashset<string> - Adam B On Feb. 13, 2015, 7:59 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30995/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2015, 7:59 a.m.) > > > Review request for mesos, Adam B, Till Toenshoff, and Vinod Kone. > > > Bugs: MESOS-2333 > https://issues.apache.org/jira/browse/MESOS-2333 > > > Repository: mesos > > > Description > ------- > > Adds an Access class which is used to turn on and off the endpoints provided > by the `mesos::Files` objects. Disabled endpoints return a "403 Forbidden" > http response. > > > Diffs > ----- > > src/files/files.hpp c8322d1381b6ba0e52bd29a4291fd3a786ce5fe0 > src/files/files.cpp 58a74b10af65ee30b7035ff00725d0f8e98529ea > src/tests/files_tests.cpp 650f1b947d87b7e17651f7378369d3ade826e412 > > Diff: https://reviews.apache.org/r/30995/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
