> On Feb. 2, 2015, 5:15 p.m., Bernd Mathiske wrote: > > src/docker/docker.cpp, line 184 > > <https://reviews.apache.org/r/30218/diff/1/?file=831932#file831932line184> > > > > Why do we not limit the wait time here any more? Is it guaranteed to be > > short if the subprocess has terminated? Also, why remove the error > > reporting? Are these error conditions expected to never occur? Potential > > error messages from read() alone are not specific to this code here.
5 seconds is a arbitrary wait time, how long you think it should be? This is going to contribute to slave startup time, so didn't want to "sleep" too long here. The error is outputed in the end, if output is failed. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30218/#review70583 ----------------------------------------------------------- On Jan. 23, 2015, 5:44 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30218/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2015, 5:44 p.m.) > > > Review request for mesos, Benjamin Hindman and Bernd Mathiske. > > > Repository: mesos > > > Description > ------- > > Add version() to docker abstraction. > > > Diffs > ----- > > src/docker/docker.hpp 3ebbc1f > src/docker/docker.cpp 3a485a2 > > Diff: https://reviews.apache.org/r/30218/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
