----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30976/#review73209 -----------------------------------------------------------
Ship it! src/examples/python/test_framework.py <https://reviews.apache.org/r/30976/#comment119448> can you document on the python driver (in previous review) why this should be an int instead of bool. src/examples/test_framework.cpp <https://reviews.apache.org/r/30976/#comment119446> cout << "Enabling...." - Vinod Kone On Feb. 18, 2015, 11:44 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30976/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2015, 11:44 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-2347 > https://issues.apache.org/jira/browse/MESOS-2347 > > > Repository: mesos > > > Description > ------- > > This updates the example frameworks to use the new API. > > It also allows example frameworks to use explicit acknowledgements by setting > MESOS_EXPLICIT_ACKNOWLEDGEMENTS in the environment. > > > Diffs > ----- > > src/examples/java/TestFramework.java > ce87de89e3868684be2cda604158134f90a499ed > src/examples/python/test_framework.py > aad6d77d4487e9998032d29e26db4b8bb885c8be > src/examples/test_framework.cpp 0a4fde50cc533f54a5dbeb2899cbe3eeb6f133cb > > Diff: https://reviews.apache.org/r/30976/diff/ > > > Testing > ------- > > make check with and without MESOS_EXPLICIT_ACKNOWLEDGEMENTS > > > Thanks, > > Ben Mahler > >
