----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30977/#review73211 -----------------------------------------------------------
Ship it! nice tests. src/tests/scheduler_tests.cpp <https://reviews.apache.org/r/30977/#comment119451> You should do a Clock::pause() and Clock::settle() here to ensure any ACK would've been sent. - Vinod Kone On Feb. 17, 2015, 6 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30977/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2015, 6 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-2347 > https://issues.apache.org/jira/browse/MESOS-2347 > > > Repository: mesos > > > Description > ------- > > In addition to the test frameworks, this adds an integration test to exercise > explicit acknowledgements. > > > Diffs > ----- > > src/tests/scheduler_tests.cpp 080ec7236246794de6c8cc7356a06331c5e48cd5 > > Diff: https://reviews.apache.org/r/30977/diff/ > > > Testing > ------- > > make check with 100 repetitions > > > Thanks, > > Ben Mahler > >
