> On Feb. 19, 2015, 10:43 p.m., Till Toenshoff wrote: > > src/tests/sorter_tests.cpp, line 279 > > <https://reviews.apache.org/r/31183/diff/1/?file=869111#file869111line279> > > > > Would be great if this one featured a descriptive comment just like the > > above, no?
Added one :) - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31183/#review73218 ----------------------------------------------------------- On Feb. 19, 2015, 11:53 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31183/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2015, 11:53 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Ben Mahler, > and Jie Yu. > > > Bugs: MESOS-2373 > https://issues.apache.org/jira/browse/MESOS-2373 > > > Repository: mesos > > > Description > ------- > > Distinguish resources from different slaves in DRFSorter. > > > Diffs > ----- > > src/master/allocator/allocator.hpp c2461a32e18dbafe637f37180f86bfa2e1d78735 > src/master/allocator/mesos/allocator.hpp > 99b40a01749b77fc7c1fa025a7ac81d5cca6272f > src/master/allocator/mesos/hierarchical.hpp > 2680d6231927867d5a8d75cbc42b81d6c75fc7f2 > src/master/allocator/sorter/drf/sorter.hpp > 966fe03de389246dc71e933f9a51ad5b55f2834d > src/master/allocator/sorter/drf/sorter.cpp > 7baee453848c7587472b2e9358c9e4ee6df6e860 > src/master/allocator/sorter/sorter.hpp > 8cd70dd91f72109222d8a0cd67cbf66ee4188ab5 > src/master/http.cpp 5e3afdf8f32a7bf146eb39e53d1543c92e6180ba > src/master/master.hpp 6a39df04514c756415354fae66c5835ada191c52 > src/master/master.cpp f10a3cffdb0b9831b2b8af0dfd30f73d1d8ed937 > src/tests/hierarchical_allocator_tests.cpp > eeecfb64540b16666915074aaffaa5d506b203bc > src/tests/mesos.hpp 60c70043c8266a422ffa03ab5a949da0bc822124 > src/tests/sorter_tests.cpp 7ba32b78bdedf754f76f0695dfd1d86aa1f1b5bf > > Diff: https://reviews.apache.org/r/31183/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Michael Park > >
