> On Feb. 20, 2015, 6:30 p.m., Jie Yu wrote: > > src/master/allocator/mesos/hierarchical.hpp, lines 795-811 > > <https://reviews.apache.org/r/30911/diff/3/?file=868707#file868707line795> > > > > Can we punt on that change right now? It does not seem to simply the > > code and it's actually more hard to read.
Reverted to ```cpp Resources resources = slaves[slaveId].available.unreserved() + slaves[slaveId].available.reserved(role); ``` - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30911/#review73294 ----------------------------------------------------------- On Feb. 21, 2015, 3:57 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30911/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2015, 3:57 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and > Vinod Kone. > > > Bugs: MESOS-2348 > https://issues.apache.org/jira/browse/MESOS-2348 > > > Repository: mesos > > > Description > ------- > > See [JIRA Ticket](https://issues.apache.org/jira/browse/MESOS-2348). > > > Diffs > ----- > > include/mesos/resources.hpp c242bcc29c490841354d6fdc8d0de16eeea602ed > src/common/resources.cpp 625922dd1abe2420736867c6043ca39be4e526ef > src/master/allocator/mesos/hierarchical.hpp > 2680d6231927867d5a8d75cbc42b81d6c75fc7f2 > src/master/master.hpp a466f9299f116e1c3aae6fc79c73c9c165383769 > src/master/validation.cpp cd1052adc877cf698f5f627eef6ff4008aa573d5 > src/slave/slave.cpp 0374ca061cb53dc7e3338366aa41b1c15fb3231c > src/tests/hierarchical_allocator_tests.cpp > eeecfb64540b16666915074aaffaa5d506b203bc > src/tests/resources_tests.cpp 3f98782fd437dba808d720bf8e9b94b8fa7e0feb > > Diff: https://reviews.apache.org/r/30911/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Michael Park > >
