----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31016/#review73457 -----------------------------------------------------------
src/slave/slave.cpp <https://reviews.apache.org/r/31016/#comment119792> Can we instead swap its name with `task_` and move the label decorator higher (right after entry into this function)? This would prevent future developers from accidentally using `task` when they meant to use `task_`. Doing the label decoration before the error checks has an added benefit of generating notifications for dropped tasks as well for the hook modules. src/slave/slave.cpp <https://reviews.apache.org/r/31016/#comment119793> Should we rather move it close to the runTask definition? Since the two are logically close. src/slave/slave.cpp <https://reviews.apache.org/r/31016/#comment119796> const ref? - Kapil Arya On Feb. 13, 2015, 6:28 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31016/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2015, 6:28 p.m.) > > > Review request for mesos, Ben Mahler and Kapil Arya. > > > Repository: mesos > > > Description > ------- > > Added decorator which gets invoked on start of runTask() sequence in the > slave. > > > Diffs > ----- > > include/mesos/hook.hpp d83ace576a2c78eb7b1e910d89d912f6df5c46ef > src/hook/manager.hpp a6594c180e772beccaf5beeaafc5cc02f69621a4 > src/hook/manager.cpp a6938d09851898dd5853d86231c9f9d9db15729b > src/slave/slave.hpp 7a399f6df50c69b7e1e12d74f076fa57b6edb1b3 > src/slave/slave.cpp ec7ec1356e745bb07484ae1755c9183b038043b3 > > Diff: https://reviews.apache.org/r/31016/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Niklas Nielsen > >
