> On Feb. 23, 2015, 7:46 p.m., Vinod Kone wrote: > > include/mesos/type_utils.hpp, line 30 > > <https://reviews.apache.org/r/30931/diff/6/?file=872930#file872930line30> > > > > An installed header cannot depend on an internal header. Does this > > include have to be in include/type_utils.hpp?
Thanks for the feedback, will move the code to another file. - Joerg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30931/#review73644 ----------------------------------------------------------- On Feb. 23, 2015, 4:06 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30931/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2015, 4:06 p.m.) > > > Review request for mesos and Till Toenshoff. > > > Bugs: MESOS-2323 > https://issues.apache.org/jira/browse/MESOS-2323 > > > Repository: mesos > > > Description > ------- > > Added flags to logs at master and slave startup. > > > Diffs > ----- > > include/mesos/type_utils.hpp cdf5864389a72002b538c263d70bcade2bdffa45 > src/common/type_utils.cpp a1704c67d04d19f65d94dbe56a61bb28561e5bf3 > src/master/master.cpp 57e86ee19879cc8a2a9b9fb69f602eea0a06e906 > src/slave/slave.cpp d44910838fc479b62200cdfd342ad13524504838 > > Diff: https://reviews.apache.org/r/30931/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joerg Schad > >
