> On Feb. 21, 2015, 1:15 a.m., Dominic Hamon wrote: > > src/slave/containerizer/isolators/cgroups/cpushare.cpp, line 421 > > <https://reviews.apache.org/r/31250/diff/1/?file=871370#file871370line421> > > > > does this scale linearly with number of processes?
it does. :( This is the only interface we have. I left a comment in the code. - Chi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31250/#review73360 ----------------------------------------------------------- On Feb. 24, 2015, 12:45 a.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31250/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2015, 12:45 a.m.) > > > Review request for mesos and Ian Downes. > > > Bugs: mesos-2103 > https://issues.apache.org/jira/browse/mesos-2103 > > > Repository: mesos > > > Description > ------- > > Ian, as discussed, I put the logic in cpu isolator for now until linux > launcher sees more and more need to report isolator-independent cgroup usage. > > > Diffs > ----- > > include/mesos/mesos.proto 9df972d750ce1e4a81d2e96cc508d6f83cad2fc8 > src/slave/containerizer/isolators/cgroups/cpushare.cpp > b6df23963f20e5f14f484d449733655d46cd6884 > src/tests/isolator_tests.cpp f7323965b94543bfda78afc4f60fc677f4900ecd > > Diff: https://reviews.apache.org/r/31250/diff/ > > > Testing > ------- > > added a new test. the test is end-to-end so that future replacement of the > actual logic won't require a change. > > > Thanks, > > Chi Zhang > >
