----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31378/#review73930 -----------------------------------------------------------
Patch looks great! Reviews applied: [31378] All tests passed. - Mesos ReviewBot On Feb. 24, 2015, 8:14 p.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31378/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2015, 8:14 p.m.) > > > Review request for mesos, Ian Downes and Jie Yu. > > > Bugs: mesos-2400 > https://issues.apache.org/jira/browse/mesos-2400 > > > Repository: mesos > > > Description > ------- > > - Used symbol NAME directly to launch the subprocess instead of the > hard-coded string. > - Replaced the static string with char[]. > > > Diffs > ----- > > src/Makefile.am 65cba64834d8d2224761105516c64c6ba203f9f3 > src/tests/ns_tests.cpp 866f0e742028ce7c693bce3b4f99005c66a4fab2 > src/tests/setns_test_helper.hpp c6bec95632f7426c76a02eaddbcedade85e17436 > src/tests/setns_test_helper.cpp eb8746bd6e75323682d9dbbf989b65e30e3c1cda > src/tests/setns_test_helper_main.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/31378/diff/ > > > Testing > ------- > > > Thanks, > > Chi Zhang > >
