> On Feb. 24, 2015, 10:32 a.m., Adam B wrote: > > docs/configuration.md, line 646 > > <https://reviews.apache.org/r/31327/diff/1/?file=873191#file873191line646> > > > > or /path/to/file? > > And shouldn't you end the `</code>` earlier, if it's only wrapping the > > path(s)? > > Also, <pre> is closed but never opened.
/path/to/file doesn't work for this flag. Good point on the end </code> - removed. > On Feb. 24, 2015, 10:32 a.m., Adam B wrote: > > docs/configuration.md, lines 684-685 > > <https://reviews.apache.org/r/31327/diff/1/?file=873191#file873191line684> > > > > Above you eliminated the "(default: crammd5)" text, presumably because > > it is inline in the description. Either way is fine by me, but please be > > consistent between the two. Where? :) Moved it to a newline (that was at least the intention) - Niklas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31327/#review73846 ----------------------------------------------------------- On Feb. 24, 2015, 4:54 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31327/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2015, 4:54 p.m.) > > > Review request for mesos, Ben Mahler, Kapil Arya, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Added new flags and removed checkpoint slave flag > > > Diffs > ----- > > docs/configuration.md 47d8ccb6a1f318b153a3509be10b8dac9a24130c > > Diff: https://reviews.apache.org/r/31327/diff/ > > > Testing > ------- > > > Thanks, > > Niklas Nielsen > >
