----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30510/#review74057 -----------------------------------------------------------
src/slave/containerizer/mesos/containerizer.hpp <https://reviews.apache.org/r/30510/#comment120557> "symlinks" seems like an implementation detail. how about s/updateVolumeSymlinks/updateVolumes/ src/slave/containerizer/mesos/containerizer.cpp <https://reviews.apache.org/r/30510/#comment120568> for consistency with how you did it in update() below, do you want to pull this down after updateVolumes()? src/slave/containerizer/mesos/containerizer.cpp <https://reviews.apache.org/r/30510/#comment120560> s/symlinks for// src/slave/containerizer/mesos/containerizer.cpp <https://reviews.apache.org/r/30510/#comment120559> s/volume symlinks/volumes/ src/slave/containerizer/mesos/containerizer.cpp <https://reviews.apache.org/r/30510/#comment120562> just point to the comments in launch(), so that there is only one place to update the comments in the future. src/slave/containerizer/mesos/containerizer.cpp <https://reviews.apache.org/r/30510/#comment120563> s/resource/resources/ src/slave/containerizer/mesos/containerizer.cpp <https://reviews.apache.org/r/30510/#comment120565> if you agree with my comment in launch(), you dont need to take "current" resources as an argument and get it from 'container'? src/slave/containerizer/mesos/containerizer.cpp <https://reviews.apache.org/r/30510/#comment120576> CHECK(resource.disk().has_persistence()); ? src/tests/persistent_volume_tests.cpp <https://reviews.apache.org/r/30510/#comment120578> s/according/according to/ src/tests/persistent_volume_tests.cpp <https://reviews.apache.org/r/30510/#comment120579> Do you also want to test for unlinking? - Vinod Kone On Feb. 23, 2015, 7:06 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30510/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2015, 7:06 a.m.) > > > Review request for mesos, Ben Mahler, Ian Downes, Michael Park, and Vinod > Kone. > > > Bugs: MESOS-2031 > https://issues.apache.org/jira/browse/MESOS-2031 > > > Repository: mesos > > > Description > ------- > > Allowed Mesos containerizer to prepare and update volumes. > > Mesos containerizer setup volumes for the container. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.hpp > 074a2d82dcd882e52f8cd62ed7493295596acb26 > src/slave/containerizer/mesos/containerizer.cpp > d5b90d12d63becfeb4c3efa9c6f5d826417f582c > src/tests/persistent_volume_tests.cpp > b4f2298069233b27f6b4b8d668753810f43bb58d > > Diff: https://reviews.apache.org/r/30510/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
