----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31424/#review74071 -----------------------------------------------------------
Ship it! src/tests/rate_limiting_tests.cpp <https://reviews.apache.org/r/31424/#comment120581> I also added a TODO to move this method out from MesosTest because it has nothing to do with Mesos right? Do you want to clean that up too (in a subsequent review)? - Vinod Kone On Feb. 25, 2015, 7:43 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31424/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2015, 7:43 p.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Resolve TODO and remove METRICS_SNAPSHOT macro > > > Diffs > ----- > > src/tests/rate_limiting_tests.cpp e4fa8f006e6a8f8804cfd47d3ad12b55cf064f99 > > Diff: https://reviews.apache.org/r/31424/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
