----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31480/#review74264 -----------------------------------------------------------
Ship it! LGTM minus the lseek errno handling. Feel free to drop it if there is no precedence in the codebase. src/slave/state.cpp <https://reviews.apache.org/r/31480/#comment120803> Should we also add strerror(errno) to inform about the lseek error? src/slave/state.cpp <https://reviews.apache.org/r/31480/#comment120804> Same as above - Kapil Arya On Feb. 26, 2015, 4:10 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31480/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2015, 4:10 a.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > ------- > > Fix check for lseek error. > > > Diffs > ----- > > src/slave/state.cpp 0329ba56367a89e3ac5b1f3fcc3e3315ccd33999 > > Diff: https://reviews.apache.org/r/31480/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
