----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31446/#review74351 -----------------------------------------------------------
Patch looks great! Reviews applied: [31446] All tests passed. - Mesos ReviewBot On Feb. 26, 2015, 6:53 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31446/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2015, 6:53 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: mesos-1830 > https://issues.apache.org/jira/browse/mesos-1830 > > > Repository: mesos > > > Description > ------- > > Add metric breakdown for terminal tasks in Slave > > > Diffs > ----- > > docs/configuration.md fc3afec248b534b1d5eb625eb66de5f90cd8cd33 > src/Makefile.am 17d0d7aa7361c3a373f6863d36b0a4767f5c05c4 > src/common/resources_utils.hpp 3758ad5da6ab04cc5ac96627c1edf05f32c8a84f > src/common/resources_utils.cpp fe04d57227fa193d6d11d2f76529c46aea74c6a1 > src/master/master.hpp e288cdb812c287be7c1986e47020fc2726e844ad > src/slave/containerizer/mesos/containerizer.hpp > ae61a0fcd19f2ba808624312401f020121baf5d4 > src/slave/containerizer/mesos/containerizer.cpp > ec4626f903d44c0911093ff763ef16ad27c418a9 > src/slave/metrics.hpp 0390461968112cac9ed84ec3cc23b264e8b4e9d7 > src/slave/metrics.cpp c32b4d8a1ff3bc5e5f5ca21eb78a036c9ea1a813 > src/slave/slave.hpp 7b58cade9ada5f0a56b4c60c502eb907ccae33b4 > src/slave/slave.cpp 9f31fa46304398e8f87b41b55d8f4cfd4aba10b9 > src/slave/state.cpp 41f6c2c4bb68cca9569b528eda4fbc74d0cf934f > src/tests/master_slave_reconciliation_tests.cpp > e60f601202fcdbb4cafac190e9b09ca6ce925260 > src/tests/master_tests.cpp 5692f072a7bfa0b795c5996a6b809f2246bb6a66 > src/tests/mesos.hpp f7a0d057edea1a7ec7ae3bb9bc729230bf7dd46d > src/tests/mesos.cpp 23f790cbb289f6483dcdfa6ecccd462360ce02f1 > src/tests/persistent_volume_tests.cpp > e739cf520040ec1db822d46202b803834370baab > src/tests/slave_tests.cpp 7ea012ab0883cc030b3e62f59879613866dab0fa > src/tests/utils.cpp 498c9aa1442c4e937a74364073b2267dde6ffcb2 > > Diff: https://reviews.apache.org/r/31446/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
