> On Feb. 26, 2015, 5:54 p.m., Dominic Hamon wrote: > > I replaced the buffers with vectors to avoid deletes here: > > https://reviews.apache.org/r/31489/ > > Timothy Chen wrote: > Sounds good, I'll discard this. > > Ben Mahler wrote: > I just noticed this patch, why did we decide to throw away the fix that > most clearly fits in with the rest of the code? Dominic's patch could have > addressed the "buffer" memory management question independently on top of > this.
True, just thought if Dominic's patch landed then this is not needed at all. If we're still need discussion around that patch I'll push this in first. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31479/#review74295 ----------------------------------------------------------- On Feb. 26, 2015, 9:10 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31479/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2015, 9:10 a.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > ------- > > Add missing deletes in stout > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 8a4fda97ee29c185471a69f60803efc193cbe922 > > Diff: https://reviews.apache.org/r/31479/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
