> On Feb. 27, 2015, 12:55 p.m., Alexander Rojas wrote: > > src/tests/slave_tests.cpp, line 1351 > > <https://reviews.apache.org/r/31514/diff/1/?file=879513#file879513line1351> > > > > I don't see any reason as to why this line had to be moved here. Can > > you explain?
It doesn't have to be moved there, it can be outside the loop as well. What's important is that we trigger a timeout for the last "ping". I'll update the comment on the loop to say "induce a health check failure" to better capture this. Thanks! - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31514/#review74476 ----------------------------------------------------------- On Feb. 27, 2015, 2:58 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31514/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2015, 2:58 a.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > SlaveTest.RateLimitSlaveShutdown now ensures that no shutdown is sent before > the rate limiting permit is satisfied. > SlaveTest.CancelSlaveShutdown now only needs to use 1 slave to test that > cancellation works. > > > Diffs > ----- > > src/Makefile.am 30c56fc4f46345f8f3c076211e8b4704a59ff28a > src/tests/limiter.hpp PRE-CREATION > src/tests/mesos.hpp 6b9656b2b858df75e725aaa042c447b755899c87 > src/tests/mesos.cpp df051d9f647ed716f06055c312f18d8d1759a437 > src/tests/slave_tests.cpp 7ea012ab0883cc030b3e62f59879613866dab0fa > > Diff: https://reviews.apache.org/r/31514/diff/ > > > Testing > ------- > > Ran the tests with 500 iterations. > > > Thanks, > > Ben Mahler > >
